Skip to content

Revert center of rotation change after pan #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

Revert center of rotation change after pan #3310

merged 1 commit into from
Aug 14, 2025

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Aug 12, 2025

Rolls back InteractorStyleManipulator center of rotation behaior to not update on pan.

Adds vtkMouseCameraTrackballPanManipulatorAutoCenter for the auto update on center of rotation for mouse only input.

Test with

npm run example InteractorStyleManipulator

Compare to
npm run example InteractorStyleManipulatorRotateCameraCenter

closes #3309

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be an option on the InteractorStyleManipulator ?

@PaulHax
Copy link
Collaborator Author

PaulHax commented Aug 12, 2025

Shouldn't it be an option on the InteractorStyleManipulator ?

Folks camera control needs are diverse. Extention is the way. Kitchen sink camera controls are a trap. But InteractionStyleManipulator is a monster already, so maybe I'm missing something and we should put a option in there?

@jeremygau
Copy link
Contributor

Shouldn't it be an option on the InteractorStyleManipulator ?

Folks camera control needs are diverse. Extention is the way. Kitchen sink camera controls are a trap. But InteractionStyleManipulator is a monster already, so maybe I'm missing something and we should put a option in there?

From my side, I didn’t understand why the behaviour changed. It has been like this for a long time and didn’t seem to bother anyone. I get that the new behaviour can be useful, but perhaps it would have been better to add it as an option rather than changing the default.

// Also allow pan with shift + left button
const shiftPanManipulator = vtkMouseCameraTrackballPanManipulator.newInstance();
shiftPanManipulator.setButton(1);
shiftPanManipulator.setShift(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have an option to enable or disable center of rotation modification. The default should remain the way it was before.

@PaulHax PaulHax force-pushed the center-rotation branch 2 times, most recently from 6bdc658 to 71890ad Compare August 12, 2025 18:51
Add vtkMouseCameraTrackballPanManipulatorAutoCenter

closes #3309
@PaulHax PaulHax changed the title chore(InteractorStyleManipulatorRotateWorld): create example Revert center of rotation change after pan Aug 12, 2025
@PaulHax
Copy link
Collaborator Author

PaulHax commented Aug 12, 2025

I rolled back the InteractorStyleManipulator behavior.

Added a vtkMouseCameraTrackballPanManipulatorAutoCenter

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Aug 14, 2025
Merged via the queue into master with commit e958b5c Aug 14, 2025
2 checks passed
@floryst floryst deleted the center-rotation branch August 14, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking change] Center of rotation changes after pan (v34.7.0)
5 participants